-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not show freq parameter on help when not necessary #296
Do not show freq parameter on help when not necessary #296
Conversation
image_tools/src/options.cpp
Outdated
@@ -61,7 +61,9 @@ bool parse_command_options( | |||
ss << " 1 - reliable (default)" << std::endl; | |||
ss << " -d: Depth of the queue: only honored if used together with 'keep last'. " << | |||
"10 (default)" << std::endl; | |||
ss << " -f: Publish frequency in Hz. 30 (default)" << std::endl; | |||
if( freq != nullptr ){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would expect this line to fail the linters. Please run the unit tests of the package locally to check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. Fixed now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm very sorry. Now it should be fixed.
b6b8ada
to
80d6436
Compare
80d6436
to
515f07e
Compare
Thank you for the improvement. |
Do not show frequency parameter on image_tools when not necessary. Relate ros2/ros2_documentation#41